Skip to content

test(asapquery): prove collector-free compatibility end to end - #499

Merged
zzylol merged 2 commits into
mainfrom
feat/asapquery-compatibility-e2e
Sep 4, 2026
Merged

zzylol merged 2 commits into
mainfrom
feat/asapquery-compatibility-e2e

Conversation

@zzylol

@zzylol zzylol commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #498. Merge only after its parent.

Completes the executable ASAPQuery compatibility profile:

  • makes the active atomic QueryPlan authoritative for warm/fallback routing, bypassing legacy serving-time shape/SID heuristics
  • fixes first catch-up batches so all complete event-time windows are emitted
  • gives Remote Write precompute sketches one canonical Planner algorithm/SID/store payload contract
  • classifies HLL SketchEnvelope configurations as HLL sketches even though raw-value accumulator dispatch intentionally does not implement HLL
  • preserves the successful engine identity on range responses
  • adds a production-process conformance test covering planner compilation, Remote Write decoding/replay/rejection, exact and sketch materialization, QueryPlan DAG execution, readiness, instant/range semantics, and exact fallback parity
  • adds a one-command real Prometheus demo and captured evidence directory
  • updates the compatibility profile from proposed design to implemented stack contract

Verification after rebasing the full 12-PR stack onto current main:

  • cargo test --locked -p control_plane --lib: 633 passed
  • cargo test --locked -p data_plane --lib -- --test-threads=1: 967 passed
  • ASAP_E2E_CARGO_TARGET_DIR=$PWD/target ./scripts/e2e.sh asapquery: passed
  • ./scripts/e2e.sh asapquery-demo: passed against real Prometheus/Pushgateway containers through the Docker socket
  • cargo clippy --locked -p control_plane -p data_plane --all-targets: passed (repository warnings remain non-fatal)
  • cargo fmt --all -- --check and git diff --check: passed

The Docker demo validates Prometheus Remote Write -> PrecomputePlan -> QueryPlan DAG -> warm instant/range results for sum_over_time, increase, rate, and quantile_over_time, plus exact fallback parity.

@zzylol
zzylol force-pushed the feat/asapquery-promql-conformance branch from f973364 to 519ebfb Compare September 4, 2026 03:13
@zzylol
zzylol force-pushed the feat/asapquery-compatibility-e2e branch from eb6bcc2 to 9ec5c92 Compare September 4, 2026 03:23
@zzylol
zzylol force-pushed the feat/asapquery-promql-conformance branch from 519ebfb to 7e4c81c Compare September 4, 2026 03:26
@zzylol
zzylol force-pushed the feat/asapquery-compatibility-e2e branch from 9ec5c92 to 13280b3 Compare September 4, 2026 03:26
@zzylol

zzylol commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Full-stack review completed against current main (including the canonical ASAPPlanner family refactor).

Fixes applied across the stack:

Validation:

  • all 12 PRs: MERGEABLE/CLEAN, GitHub MVP backend successful
  • control-plane library: 633 passed
  • data-plane library, serial: 967 passed
  • ASAPQuery process E2E passed
  • real Docker/Prometheus Remote Write demo passed
  • ordinary all-target clippy, fmt, and diff checks passed (the repository still has pre-existing non-fatal clippy warnings)

No PR was merged. Review/merge in stack order from #472 through #499.

@zzylol
zzylol changed the base branch from feat/asapquery-promql-conformance to main September 4, 2026 03:43
@zzylol
zzylol merged commit 422b54e into main Sep 4, 2026
1 check passed
@zzylol
zzylol deleted the feat/asapquery-compatibility-e2e branch September 12, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant